get rid of redundant constructor

Signed-off-by: Sergei Malafeev <sergeymalafeev@gmail.com>
opentracing-contrib · May 28, 2019 · 9d2d52e · 9d2d52e
1 parent a44f7b7
commit 9d2d52e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/...s-redisson/src/main/java/io/opentracing/contrib/redis/redisson/TracingRedissonClient.java b/...s-redisson/src/main/java/io/opentracing/contrib/redis/redisson/TracingRedissonClient.java
@@ -13,7 +13,6 @@
  */
 package io.opentracing.contrib.redis.redisson;
 
-import io.opentracing.Tracer;
 import io.opentracing.contrib.redis.common.TracingConfiguration;
 import java.util.concurrent.TimeUnit;
 import org.redisson.api.BatchOptions;
@@ -82,14 +81,6 @@ public class TracingRedissonClient implements RedissonClient {
   private final RedissonClient redissonClient;
   private final TracingRedissonHelper tracingRedissonHelper;
 
-  public TracingRedissonClient(RedissonClient redissonClient, Tracer tracer,
-      boolean traceWithActiveSpanOnly) {
-    this.redissonClient = redissonClient;
-    this.tracingRedissonHelper = new TracingRedissonHelper(
-        new TracingConfiguration.Builder(tracer).traceWithActiveSpanOnly(traceWithActiveSpanOnly)
-            .build());
-  }
-
   public TracingRedissonClient(RedissonClient redissonClient, TracingConfiguration configuration) {
     this.redissonClient = redissonClient;
     this.tracingRedissonHelper = new TracingRedissonHelper(configuration);

diff --git a/...dis-redisson/src/test/java/io/opentracing/contrib/redis/redisson/TracingRedissonTest.java b/...dis-redisson/src/test/java/io/opentracing/contrib/redis/redisson/TracingRedissonTest.java
@@ -61,7 +61,8 @@ public void before() {
     Config config = new Config();
     config.useSingleServer().setAddress("redis://127.0.0.1:6379");
 
-    client = new TracingRedissonClient(Redisson.create(config), tracer, false);
+    client = new TracingRedissonClient(Redisson.create(config),
+        new TracingConfiguration.Builder(tracer).build());
   }
 
   @After
@@ -195,10 +196,10 @@ public void test_config_span_name() throws Exception {
     config.useSingleServer().setAddress("redis://127.0.0.1:6379");
 
     RedissonClient customClient = new TracingRedissonClient(Redisson.create(config),
-            new TracingConfiguration.Builder(tracer)
-                    .traceWithActiveSpanOnly(true)
-                    .withSpanNameProvider(operation -> "Redis." + operation)
-                    .build());
+        new TracingConfiguration.Builder(tracer)
+            .traceWithActiveSpanOnly(true)
+            .withSpanNameProvider(operation -> "Redis." + operation)
+            .build());
 
     try (Scope ignore = tracer.buildSpan("test").startActive(true)) {
       RMap<String, String> map = customClient.getMap("map");