Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue Span in stages of RedisFuture #13

Merged

Conversation

Natheee
Copy link
Contributor

@Natheee Natheee commented Oct 3, 2018

Hi guys!

I use opentracing spring boot on my project with many futures and completationStages and I notice that some of my spans wasn't attach to my trace when I use lettuce async operations. I found that when I make some "thenApply", "thenCompose" on RedisFuture, the tracer lost the current scope and span.

@malafeev malafeev self-requested a review October 3, 2018 13:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 64

  • 14 of 362 (3.87%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 4.295%

Changes Missing Coverage Covered Lines Changed/Added Lines %
opentracing-redis-lettuce/src/main/java/io/opentracing/contrib/redis/lettuce/CompletableRedisFuture.java 3 5 60.0%
opentracing-redis-lettuce/src/main/java/io/opentracing/contrib/redis/lettuce/TracingRedisAsyncCommands.java 11 357 3.08%
Totals Coverage Status
Change from base Build 62: 0.1%
Covered Lines: 469
Relevant Lines: 10919

💛 - Coveralls

@malafeev malafeev merged commit 9c54e18 into opentracing-contrib:master Oct 3, 2018
@malafeev
Copy link

malafeev commented Oct 3, 2018

thanks @Natheee

@Natheee
Copy link
Contributor Author

Natheee commented Oct 3, 2018

Could you release the project in order to use it now?

@malafeev
Copy link

malafeev commented Oct 3, 2018

yes, I will release next hour but in maven central new version will be during 24 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants