Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redis-common): span add extension tags #46

Merged
merged 1 commit into from
Sep 27, 2019
Merged

feat(redis-common): span add extension tags #46

merged 1 commit into from
Sep 27, 2019

Conversation

duoyuli
Copy link
Contributor

@duoyuli duoyuli commented Sep 27, 2019

span add extension tags

@malafeev
Copy link

@hiColors what is the purpose if this PR? What is the issue?

import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.*;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't use "*"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, ide smart import, i will fix it.

@duoyuli
Copy link
Contributor Author

duoyuli commented Sep 27, 2019

@hiColors what is the purpose if this PR? What is the issue?

for this #44

in springboot application, sometimes it has multi redis, we will add extension tags remark different datasource.

@malafeev malafeev merged commit 81fe341 into opentracing-contrib:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants