Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tracing support for JedisSentinelPool #7

Merged
merged 24 commits into from
Jul 25, 2018

Conversation

avnandu
Copy link
Contributor

@avnandu avnandu commented Jul 25, 2018

Now has class TracingJedisSentinelPool.java to allow tracing on JedisSentinelPool objects.

@malafeev malafeev self-requested a review July 25, 2018 16:11
@coveralls
Copy link

Pull Request Test Coverage Report for Build 34

  • 19 of 77 (24.68%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 1.098%

Changes Missing Coverage Covered Lines Changed/Added Lines %
opentracing-redis-jedis/src/main/java/io/opentracing/contrib/redis/jedis/TracingJedisSentinelPool.java 19 77 24.68%
Totals Coverage Status
Change from base Build 33: 0.2%
Covered Lines: 114
Relevant Lines: 10382

💛 - Coveralls

@malafeev malafeev merged commit 0330ee5 into opentracing-contrib:master Jul 25, 2018
@malafeev
Copy link

thanks @avnandu

@avnandu
Copy link
Contributor Author

avnandu commented Jul 25, 2018

@malafeev has the new release been updated in maven? It is only showing 0.0.4 in the maven central repo. Thanks!

@malafeev
Copy link

@avnandu it took time to arrive. But now 0.0.5 is in maven central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants