Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spring-messaging modules #87

Merged
merged 1 commit into from
Dec 20, 2017

Conversation

gytis
Copy link
Collaborator

@gytis gytis commented Dec 20, 2017

PR pending to move the code to a separate project: opentracing-contrib/java-spring-messaging#2

@pavolloffay
Copy link
Contributor

CI failed, I have restarted it

@pavolloffay
Copy link
Contributor

failed again

@gytis
Copy link
Collaborator Author

gytis commented Dec 20, 2017

Do you think that this is related somehow? The only common file that I've modified is root pom.xml and only to remove module declarations.

@malafeev
Copy link

Looks like all builds started to fail: https://travis-ci.org/opentracing-contrib/java-spring-cloud/builds

@pavolloffay
Copy link
Contributor

locally it passed, master too

@pavolloffay
Copy link
Contributor

@alesj do you know why travis fails on this

Tests in error: 

  testListenerSpans(io.opentracing.contrib.spring.cloud.jms.JmsArtemisStarterTest): Condition with lambda expression in io.opentracing.contrib.spring.cloud.jms.JmsArtemisStarterTest was not fulfilled within 10 seconds.

@pavolloffay
Copy link
Contributor

I will merge, it should be safe and it's not related to this PR.

@pavolloffay pavolloffay merged commit 4bb93b2 into opentracing-contrib:master Dec 20, 2017
@pavolloffay pavolloffay mentioned this pull request Dec 20, 2017
@alesj
Copy link
Collaborator

alesj commented Dec 21, 2017

@pavolloffay nope, no idea. What changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants