Add upstream address and name tags #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a request is redirected to an upstream, then it is not visible where it went. The ngx_http_upstream module maintains a variable "upstream_addr" for the resolved IP address + port information. It also sets the name of the used upstream config entry to the request as request->upstream->upstream->host. So add that information to the new tags "upstream.address" and "upstream.name".
|
The failing docker_image build in |
rnburn
approved these changes
Aug 6, 2019
|
Looks good. I'll try to figure out what's going on with the grpc build. I think maybe the version needs to bumped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a request is redirected to an upstream, then it is not visible
where it went. The ngx_http_upstream module maintains a variable
"upstream_addr" for the resolved IP address + port information. It
also sets the name of the used upstream config entry to the request
as request->upstream->upstream->host.
So add that information to the new tags "upstream.address" and
"upstream.name".