Build modules against same GLIBC as for official Nginx image #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, this breaks usage of the binary on all Ubuntu LTS at the very least. If the |
Switching from using Ubuntu to Debian for the CI image to build binaries is necessary because of compatibility issues with GLIBC versions. Currently, the docker image for nginx uses `debian:stable` as its base. However, latest nginx opentracing modules built on `ubuntu:23` has newer versions of GLIBC, causing problems when trying to use the nginx docker image to deploy the latest binaries on the release page. For example, when trying to integrate the latest release (v0.34.0) of nginx-opentracing with nginx Docker images, there are compatibility issues. nginx-opentracing v0.34.0 needs GLIBC 2.38, but nginx:1.25.4 has GLIBC 2.36, causing errors like: ``` The latest release (v0.34.0) of nginx-opentracing is no longer compatible with nginx's debian-based docker images. nginx-opentracing v0.34.0 requires GLIBC 2.38, while e.g. nginx:1.25.4 has GLIBC 2.36: ``` Switching to Debian as the standard base image will help prevent future problems with different GLIBC versions and make integration smoother.
|
@lucacome Would you like tp review those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted the problem described in DataDog/dd-opentracing-cpp#276 (comment)
What we have now?
We build docker images base on official nginx images (debian or alpine):
nginx-opentracing/Dockerfile
Line 244 in ee6c786
In same time we build bin modules for releasing using image ubuntu:2023 build/Dockerfile.
The problem that nginx images most of time would have older GLIBC version.
@dgoffredo wrote:
Proposals
@lucacome What will be your thoughts about this?