Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build modules for Nginx 1.27.0 #621

Merged
merged 4 commits into from
Jun 1, 2024
Merged

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented May 31, 2024

Also added 1.26.1.

@oseoin
Copy link
Contributor Author

oseoin commented May 31, 2024

Not sure if the intention is to keep multiple point releases for each version, happy to clean up 1.25 and 1.26 to only use the latest as part of this PR if needed @miry? Thanks!

@miry
Copy link
Collaborator

miry commented May 31, 2024

@oseoin If you can cleanup, it would be nice.

Remove earlier versions of 1.25 and 1.26
Copy link
Collaborator

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave 1.26.0 since it's pretty new

@oseoin oseoin requested a review from lucacome June 1, 2024 20:38
@lucacome lucacome enabled auto-merge (squash) June 1, 2024 20:43
@lucacome lucacome merged commit db7f050 into opentracing-contrib:master Jun 1, 2024
29 checks passed
@miry
Copy link
Collaborator

miry commented Jun 2, 2024

released a new version with new nginx modules: https://github.com/opentracing-contrib/nginx-opentracing/releases/tag/v0.35.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants