Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail against Python 3.x #16

Closed
yurishkuro opened this issue Aug 20, 2016 · 2 comments
Closed

Tests fail against Python 3.x #16

yurishkuro opened this issue Aug 20, 2016 · 2 comments

Comments

@yurishkuro
Copy link
Member

Per @cybergrind's comment:

Unfortunately protobuf tests aren't fine on python 3 due discrepancies in implementation of bytearray support
https://travis-ci.org/opentracing/basictracer-python/jobs/153806259
Looks like protocolbuffers/protobuf#1173 caused it

I believe we can get rid of jumpahead now just to not break current applications that aren't rely on protobuf serialization and fix tests in separate branch. Btw it isn't look like it going to be fixed in nearest future in protobuf repo.
@yurishkuro yurishkuro mentioned this issue Aug 20, 2016
Merged
@tedsuo
Copy link
Member

tedsuo commented Apr 17, 2017

PR #20 fixes this.

@tedsuo tedsuo mentioned this issue Apr 17, 2017
Merged
@bhs
Copy link
Contributor

bhs commented Apr 23, 2017

As @tedsuo mentioned, this was fixed by #20.

@bhs bhs closed this as completed Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tedsuo @bhs @yurishkuro