Python3 doesn't have random.jumpahead #15
Conversation
| @@ -17,5 +16,5 @@ def generate_id(): | |||
| pid = os.getpid() | |||
| if (_fork_guard_pid == 0) or (_fork_guard_pid != pid): | |||
| _fork_guard_pid = pid | |||
| guid_rng.jumpahead(int(1000000 * time.time()) ^ pid) | |||
| guid_rng.seed(random.randrange(0, 0xFFFFFFFF)) | |||
There was a problem hiding this comment.
wouldn't this produce identical result across all forks? The XOR with pid was adding uniqueness to each fork.
There was a problem hiding this comment.
Seed is fine, but the arg must incorporate pid (and should incorporate time IMO)
|
If we want this change so that it works with python3, we should test it with 3. Can you add it to .travis.yaml matrix? |
cybergrind
force-pushed
the
master
branch
2 times, most recently
from
30e534a
to
2ceba0d
Compare
|
I've added time + pid into seed. Unfortunately protobuf tests aren't fine on python 3 due discrepancies in implementation of bytearray support I believe we can get rid of jumpahead now just to not break current applications that aren't rely on protobuf serialization and fix tests in separate branch. Btw it isn't look like it going to be fixed in nearest future in protobuf repo. |
|
OK fair enough, I will accept it. Thanks for checking against 3.x, I booked it as a separate issue maybe someone will care to fix: #16 |
Replace it with seed call