Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Commit

Permalink
Merge 6c2f6b6 into d91d707
Browse files Browse the repository at this point in the history
  • Loading branch information
qudongfang committed Aug 7, 2019
2 parents d91d707 + 6c2f6b6 commit aff8e9e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
5 changes: 2 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,15 @@

If you would like to contribute code you can do so through GitHub by forking the repository and sending a pull request (on a branch other than `master` or `gh-pages`).


## License

By contributing your code, you agree to license your contribution under the terms of the APLv2: https://github.com/opentracing/opentracing-java/blob/master/LICENSE
By contributing your code, you agree to license your contribution under the terms of the APLv2: <https://github.com/opentracing/opentracing-java/blob/master/LICENSE>

All files are released with the Apache 2.0 license.

If you are adding a new file it should have a header like below. This can be automatically added by running `./mvnw com.mycila:license-maven-plugin:format`.

```
```java
/**
* Copyright 2016-2019 The OpenTracing Authors
*
Expand Down
9 changes: 8 additions & 1 deletion opentracing-api/src/main/java/io/opentracing/tag/Tags.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
* semantic information about the spans. Tracers may expose additional features based on these
* standardized data points. Tag names follow a general structure of namespacing.
*
* @see <a href="https://github.com/opentracing/specification/blob/master/semantic_conventions.md">https://github.com/opentracing/specification/blob/master/semantic_conventions.md</a>
* @see <a href="https://github.com/opentracing/specification/blob/1.1/semantic_conventions.md">OpenTracing Specification Semantic Conventions v1.1</a>
*/

public final class Tags {
Expand Down Expand Up @@ -60,6 +60,13 @@ private Tags() {
*/
public static final StringTag HTTP_METHOD = new StringTag("http.method");

/**
* PEER_ADDRESS records remote "address", suitable for use in a networking client library.
* This may be a `"ip:port"`, a bare `"hostname"`, a FQDN,
* or even a JDBC substring like `"mysql://prod-db:3306"`.
*/
public static final StringTag PEER_ADDRESS = new StringTag("peer.address");

/**
* PEER_HOST_IPV4 records IPv4 host address of the peer.
*/
Expand Down

0 comments on commit aff8e9e

Please sign in to comment.