Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

out of date I think #81

Closed
codefromthecrypt opened this issue Jan 5, 2017 · 5 comments
Closed

out of date I think #81

codefromthecrypt opened this issue Jan 5, 2017 · 5 comments

Comments

@codefromthecrypt
Copy link
Contributor

I think many are calling OpenTracing version 1 or something and it is here 0.20.7 including methods marked deprecated. If these methods are in fact no longer in the api, they should be removed instead of leading people on. If the api is version 1, then it should probably be marked so..

sound sensible?

@wu-sheng
Copy link
Member

Maybe we should release OpenTracing-java 1.0, remove all @deprecated APIs, and only follow the Spec 1.0

@bhs
Copy link
Contributor

bhs commented Feb 13, 2017

The OpenTracing spec itself is at v1.0; OT-Java is at whatever version it's at. :)

I am still grumpy that it has all of these impl helper classes (AbstractSpan, etc) in the core repo... they do not need to be there and tend to confuse people. And getting rid of the deprecated bits also makes plenty of sense.

@wu-sheng
Copy link
Member

The whole opentracing-impl thing is not part of Official OpenTracing-Java. :P

For me, these AbstractSpan classes (in opentracing-impl module, including NoopSpan) like demonstrations or reference implementations. Because OT does not require them.

@adriancole thoughts?

@sjoerdtalsma
Copy link
Contributor

sjoerdtalsma commented Feb 22, 2017

@bhs

I am still grumpy that it has all of these impl helper classes (AbstractSpan, etc) in the core repo...

👍 Plus that you can't actually use them unless you move yourself into the io.opentracing.impl package (which may become overcrowded real soon for this exact reason!)

Maybe a good spring cleanup is in order?

@tedsuo
Copy link
Member

tedsuo commented Jun 5, 2017

Spring cleaning (for issues) here: closing this issue as it is out of date. There is a milestone for v1.0.0 release of java, which can be found here: https://github.com/opentracing/opentracing-java/milestone/1

Feel free to create a new issue discussing what should be in the v1.0.0 milestone if you are interested.

@tedsuo tedsuo closed this as completed Jun 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants