-
Notifications
You must be signed in to change notification settings - Fork 344
Change copyright comment in java files from /** */ style to /* */. #143
Change copyright comment in java files from /** */ style to /* */. #143
Conversation
This avoids automatically adding <P> between the paragraphs every time an IDE (like IntelliJ) auto-formats the code.
import java.util.HashMap; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not recommended by many style checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, must've been a side-effect from my IntelliJ settings, I'll correct this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to fix only license comments in this PR, and define checkstyle in another one. If we don't define checkstyle e.g. order of imports, comment style code will be different in every PR
* @see ActiveSpanSource | ||
* @see Tracer#activeSpan() | ||
*/ | ||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you change this manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, must have been an IntelliJ autoformat.
By the way, I agree with you on the license-only commit; that was my intention, the formatting 'came free' by the tooling 😉
I'll change the code to "license-only" and try to revert all formatting changes, please don't merge yet. |
Looks like the accidental auto-import changes were finally reverted. |
This avoids automatically adding
<P>
between the paragraphs every time an IDE (like IntelliJ) auto-formats the code.