This repository has been archived by the owner on May 23, 2023. It is now read-only.
Qualify use of GlobalTracer #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inasmuch as a singleton mechanism is needed in some places, it ought to be part of OT-Java's core API. That said, it's not a recommended best practice when more modern options are available. Closes #140.
|
(cc @adriancole) |
pavolloffay
approved these changes
May 30, 2017
|
I'll merge this since it's an improvement and only affects documentation – if there are concerns large or small, happy to address in follow-ons. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inasmuch as a singleton mechanism is needed in some places, it ought to be part of OT-Java's core API. That said, it's not a recommended best practice when more modern options are available.
Closes #140.