Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Add constants for log fields #153

Merged
merged 2 commits into from
Jun 5, 2017
Merged

Add constants for log fields #153

merged 2 commits into from
Jun 5, 2017

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 5, 2017 •
edited
Loading

Fixes #146

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 67.34% when pulling 63edc90 on add-log-constants into 649d9bf on master.

objectiser
objectiser approved these changes Jun 5, 2017
View reviewed changes
Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Define them in alphabetical order, as in the semantic conventions doc.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 67.34% when pulling af58333 on add-log-constants into 649d9bf on master.

@yurishkuro yurishkuro merged commit c37deae into master Jun 5, 2017
@pavolloffay
Copy link
Member

wow this happened super fast. Could we wait some time before merging? Quite some people complained that changes here happen very quickly.

@yurishkuro
Copy link
Member Author

My bad

@pavolloffay pavolloffay deleted the add-log-constants branch September 25, 2017 21:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@objectiser objectiser objectiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yurishkuro @coveralls @pavolloffay @objectiser