This repository has been archived by the owner on May 23, 2023. It is now read-only.
Add generic typed setTag/withTag #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces the need to call Tags.SOMETAG.getKey() and adds type safety for setTag if done from the span. Fixes opentracing#271
tylerbenson
force-pushed
the
tyler/withtag
branch
from
1a8e54a
to
aa1eb08
Compare
|
+1 |
|
Nice one. |
|
If someone implements the Span interface (e.g. as a decorator), then any change to the interface is a breaking change. But we typically allowed additions. |
|
We have 2 approvals. @tedsuo @austinlparker do you want to review? |
carlosalberto
approved these changes
Oct 14, 2018
|
+1 |
|
One thing to note, I didn't follow @cwe1ss's suggestion to split the method declaration out by type. I don't have anything against that. If y'all prefer the non-generic option I can do that instead. Thoughts? |
|
LGTM |
|
@yurishkuro Approved - is it ok if I go ahead and merge? |
carlosalberto
added a commit
that referenced
this pull request
Mar 25, 2019
* Deprecate the StringTag.set() overload taking a StringTag. (#262) * Implement Trace Identifiers. (#280) * Bump JaCoCo to use a Java 10 friendly version (#306) * Remove finish span on close (#301) * Deprecate finishSpanOnClose on activation. * Add ScopeManager.activeSpan() and Tracer.activateSpan(). * Clarify the API changes and deprecations. * Add an error reporting sample to opentracing-testbed. * Simple layer on top of ByteBuffer for BINARY format. (#276) * Add generic typed setTag/withTag (#311) * Allow injecting into maps of type Map<String,Object> (#310) * Add simple registerIfAbsent to global tracer (#289) * Split Inject and Extract Builtin interfaces (#316) * Deprecate ScopeManager.active() (#326) * Make Tracer extends Closable. (#329) * Do not make isRegistered() synchronized. (#333) * Deprecate AutoFinishScopeManager (#335)
This was referenced Jun 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the need to call Tags.SOMETAG.getKey() and adds type safety for setTag if done from the span.
Fixes #271