This repository has been archived by the owner on May 23, 2023. It is now read-only.
Revert PR 287 which added service tag #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3e78ba6.
tylerbenson
force-pushed
the
revert-287-service-tag
branch
from
797b89f
to
8476660
Compare
|
+1 |
pavolloffay
approved these changes
Dec 6, 2018
yurishkuro
reviewed
Dec 6, 2018
| * | ||
| * @see #PEER_SERVICE | ||
| */ | ||
| public static final StringTag SERVICE = new StringTag("service"); |
There was a problem hiding this comment.
Why can't this be deprecated instead of removed?
There was a problem hiding this comment.
+1 here. This would be breaking things.
There was a problem hiding this comment.
This tag was not present in 0.31.0, so this would only be a breaking change for someone using a unofficial build. That is the main reason I'm pushing to get it removed before 0.32.0 so it doesn't have to go through a deprecation period.
carlosalberto
approved these changes
Dec 6, 2018
carlosalberto
approved these changes
Dec 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See opentracing/specification#131.
Until this gets resolved, I don't think it should be included in an official release.
Reverts #287.
Note, this is being merged into the
v0.32.0feature branch to be part of the next RC.