Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Set version to 0.33.1-SNAPSHOT. #345

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Set version to 0.33.1-SNAPSHOT. #345

merged 1 commit into from
Apr 30, 2019

Conversation

carlosalberto
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.18% when pulling b54e60b on v0.33.0_set_version into 62df776 on v0.33.0.

sjoerdtalsma
sjoerdtalsma approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@sjoerdtalsma sjoerdtalsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

If I can remember correctly, I think I manually updated the snapshot once too.
Can't we integrate this automatically in the release job after a merge-back somehow?

@pavolloffay
Copy link
Member

The next snapshot version should be automatically updated by release script. If that is not the case something is broken

@carlosalberto
Copy link
Collaborator Author

@pavolloffay As far as I remember, once a release/release-candidate happens, the version is automatically changed - but I did this update for people testing this branch and/or using the bintray snapshots ;)

@carlosalberto
Copy link
Collaborator Author

Hey @sjoerdtalsma

Can't we integrate this automatically in the release job after a merge-back somehow?

Would be nice to have, yes ;)

@carlosalberto carlosalberto merged commit 150543a into v0.33.0 Apr 30, 2019
carlosalberto added a commit that referenced this pull request May 6, 2019
@carlosalberto
V0.33.0 (#348)
5ed6a47 
* Remove Deprecated members. (#339)
* Set version to 0.33.1-SNAPSHOT. (#345)
* Update CHANGELOG to include v0.33.0 (#347)
@carlosalberto carlosalberto deleted the v0.33.0_set_version branch January 16, 2020 21:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sjoerdtalsma sjoerdtalsma sjoerdtalsma approved these changes

@yurishkuro yurishkuro yurishkuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carlosalberto @coveralls @pavolloffay @sjoerdtalsma @yurishkuro