Adjust to new log() parameters

opentracing · Sep 14, 2016 · 5f43e5c · 5f43e5c
1 parent 3ad9b36
commit 5f43e5c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/src/examples/demo/demo.js b/src/examples/demo/demo.js
@@ -18,10 +18,12 @@ setTimeout(() => {
     const child = tracer.startSpan('child_span', { childOf: parent });
     child.setTag('alpha', '200');
     child.setTag('beta', '50');
+    child.log({state: "waiting"})
 
     console.log('Waiting...');
     setTimeout(() => {
         console.log('Finishing child and parent.')
+        child.log({state: "done"})
         child.finish();
         parent.finish();
 

diff --git a/src/mock_tracer/mock_span.js b/src/mock_tracer/mock_span.js
@@ -29,8 +29,11 @@ export default class MockSpan extends opentracing.Span {
         }
     }
 
-    _log(fields) {
-        this._logs.push(fields);
+    _log(fields, timestamp) {
+        this._logs.push({
+            fields    : fields,
+            timestamp : timestamp,
+        });
     }
 
     _finish(finishTime) {

diff --git a/test/api_compatibility.js b/test/api_compatibility.js
@@ -109,7 +109,11 @@ module.exports = function apiCompatibilityChecks(tracerFactory, options) {
                 {name: 'setTag', args: ['key', 'value'], chainable: true},
                 {name: 'addTags', args: [{'key': 'value'}], chainable: true},
                 {name: 'log', args: [
-                    {'event': 'event-name', 'payload': {'key': 'value'}}
+                    {'key1': 'val1', 'key2': {'nested': 'value'}}
+                ], chainable: false},
+                {name: 'log', args: [
+                    {'key1': 'val1', 'key2': {'nested': 'value'}},
+                    Date.now(),
                 ], chainable: false},
                 {name: 'logEvent', args: ['eventName', null], chainable: false},
                 {name: 'logEvent', args: ['eventName', {'key': 'value'}], chainable: false},