-
Notifications
You must be signed in to change notification settings - Fork 145
Update API compatibility testing documentation #78
Comments
@yurishkuro Still missing |
hm, it worked for me, although bombed on another issue #79, which might be related. Is there a way to make TypeScript export the default? |
Not sure, I know it's also the new behaviour of Babel since version 6. For babel there is a plugin to get the old behaviour back, I don't know about TypeScript. This is related to converting |
Found a few discussions about this: |
I don't see any problems with requiring |
Yeah, I overlooked this in my PR. |
Given that README uses
|
I would go after what the NodeJS LTS versions we are targeting support, and they don't support
|
@felixfbecker @yurishkuro I'm taking a look at open issues... what is the status here? I am not knowledgeable enough about Node to have an opinion, but would like to agree on what we think is best (even if we don't have time to do the work right now). |
I think this should be fixed in the README on latest master:
(it destructures all the exports and cherry-picks |
@felixfbecker SGTM! |
See current master (Fix how requiring apiCompatibilityChecks #85 now merged in) :) |
closing per #85 |
The current documentation says to use this snippet to run API compatibility tests:
However, since version
0.14
, it should be instead:See: https://github.com/opentracing/opentracing-javascript#api-compatibility-testing
The text was updated successfully, but these errors were encountered: