This repository has been archived by the owner on May 23, 2023. It is now read-only.
Fix typo in compatibility snippet #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Apr 26, 2017
| const apiCompatibilityChecks = require('opentracing/lib/test/api_compatibility.js'); | ||
| apiCompatibilityCheck(() => new CustomTracer()); | ||
| const { apiCompatibilityChecks } = require('opentracing/lib/test/api_compatibility.js'); | ||
| apiCompatibilityChecks(() => new CustomTracer()); |
There was a problem hiding this comment.
according to #78, this is also missing .default after require(), could you add it? Then I can merge.
Thanks!
There was a problem hiding this comment.
You may do both, as it both an named and a default export. Shall I still change it?
There was a problem hiding this comment.
People claim it does not work without .default in some later versions (of Babel?). I am not an expert in JS ecosystem. I will merge as is, you may want to reply to that other ticket.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Thanks for this great project, I am excited to use it. I have found a little typo I wanted to fix real quick 馃憤
Thanks for your patience!