Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

remove dependency on lodash #104

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

rochdev
Copy link
Contributor

@rochdev rochdev commented Apr 4, 2018

This PR removes the dependency on lodash since it was causing dependency problems for depending libraries. It was also only used for functionalities that are readily available in pure JS. This problem existed as well when underscore was used instead of lodash (#75).

Fixes #95

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.525% when pulling b5de1b7 on rochdev:remove-lodash-dep into 3abef18 on opentracing:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.525% when pulling b5de1b7 on rochdev:remove-lodash-dep into 3abef18 on opentracing:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.525% when pulling b5de1b7 on rochdev:remove-lodash-dep into 3abef18 on opentracing:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.525% when pulling b5de1b7 on rochdev:remove-lodash-dep into 3abef18 on opentracing:master.

@coveralls
Copy link

coveralls commented Apr 4, 2018

Coverage Status

Coverage remained the same at 88.525% when pulling b5de1b7 on rochdev:remove-lodash-dep into 3abef18 on opentracing:master.

@yurishkuro
Copy link
Member

lgtm

@bcronin ok to merge?

Copy link
Collaborator

@bcronin bcronin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

With regards to, "functionalities that are readily available in pure JS", I'm not sure how old of platforms opentracing-javascript is supposed to support. Given that this affects the mock tracer only, I'm not very worried about this. However, if it does seem concerning, it also seems like it'd be very easy to rewrite these as pure for loops.

This looks 👍 as-is to me, though given that it's the mock tracer only.

Copy link
Member

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @rochdev ! Should we merge? Also do we plan to ship a new release or do we want to include other fixes before?

@yurishkuro yurishkuro merged commit 3b8bd98 into opentracing:master Apr 5, 2018
@yurishkuro
Copy link
Member

I think it's fine to do a new release

@palazzem
Copy link
Member

palazzem commented Apr 6, 2018

Great @yurishkuro ! who's in charge for that? Something I can help with?

@rochdev rochdev deleted the remove-lodash-dep branch April 6, 2018 15:23
@yurishkuro
Copy link
Member

I can probably do the release, but could use some help with preparing a PR with changelog changes

@palazzem
Copy link
Member

palazzem commented Apr 6, 2018

That would be great! sure thing we'll help with the changelog (so me or @rochdev )

@rochdev
Copy link
Contributor Author

rochdev commented Apr 6, 2018

I can help with the changelog. I'll try to have a PR later on today.

@rochdev
Copy link
Contributor Author

rochdev commented Apr 6, 2018

See #106

@yurishkuro
Copy link
Member

Published 0.14.3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants