Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Fix circular dependency in mock_context #154

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Fix circular dependency in mock_context #154

merged 1 commit into from
Nov 5, 2020

Conversation

jdmoody
Copy link
Contributor

@jdmoody jdmoody commented Nov 4, 2020

There seems to be a legitimate circular dependency here that causes problems when I build this library using Snowpack:

  1. ./index.ts imports ./mock_tracer/index.ts
  2. ./mock_tracer/index.ts imports ./mock_tracer/mock_tracer.ts
  3. ./mock_tracer/mock_tracer.ts imports ./mock_tracer/mock_context.ts
  4. ./mock_tracer/mock_context.ts imports ./index.ts

I think it should be fixed by simply importing SpanContext directly rather than importing the full ./index.ts.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coveralls
Copy link

coveralls commented Nov 4, 2020

Coverage Status

Coverage remained the same at 88.889% when pulling 386e6ad on jdmoody:fix-mock-context-cycle into 07e847f on opentracing:master.

@yurishkuro yurishkuro closed this Nov 5, 2020
@yurishkuro yurishkuro reopened this Nov 5, 2020
@yurishkuro yurishkuro merged commit 2b5d78a into opentracing:master Nov 5, 2020
@jdmoody jdmoody deleted the fix-mock-context-cycle branch November 5, 2020 23:45
@jdmoody
Copy link
Contributor Author

jdmoody commented Nov 5, 2020

Thanks for the quick review + merge! 🙏

I'd love to get a patch version with this out, if possible. I believe anyone trying to use opentracing with Snowpack will run into this, otherwise.

@yurishkuro
Copy link
Member

Released as v0.14.15

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants