This repository has been archived by the owner on May 23, 2023. It is now read-only.
Fix global tracer delegation #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base Tracer class wraps the `startSpan`, `inject`, and `extract` functions with some compatibility utilities. Subclasses need to override the `_`-prefixed functions to avoid overriding the wrapper functionality.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base Tracer class wraps the
startSpan,inject, andextractfunctions with some compatibility utilities. Subclasses need to override the_-prefixed functions to avoid overriding the wrapper functionality.With the current implementation, the
childOfoption does not work with LightStep if you use the global tracer function. It tells me that there is an unknown optionchildOf, since the delegate is overriding the wrong functions.