Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Handle non-extending Span classes in Reference constructor #162

Commits on Mar 27, 2021

  1. Handle non-extending Span classes in Reference constructor

    The interface allows passing both Span and SpanContext as an argument
    for creating References.
    But the `instanceof` check won't always work in runtime, for example, for cases
    when Span implementation does not extend the opentracing.Span class, but just
    implements the interface.
    The popular `jaeger-client-node` library does exactly that.
    
    This produces hard-to-track errors.
    
    I added additional checks to distinguish between Span and SpanContext instances.
    
    Resolves: opentracing#161
    treble-snake committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    448e3db View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2021

  1. Improve tests

    Remove unnecessary fixtures, use simpler approach.
    treble-snake committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    e55f26b View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Rename inner function

    Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
    treble-snake and yurishkuro committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    6222bc6 View commit details
    Browse the repository at this point in the history