Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

BinaryCarrier does not fulfill the API contract for binary carrier objects #60

Merged
merged 1 commit into from
Nov 27, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ History
0.13.1 (unreleased)
-------------------

- No changes yet
- `BinaryCarrier` now fulfills the API contract that binary carrier objects have a `buffer` property.


0.13.0 (2016-10-14)
Expand Down
2 changes: 1 addition & 1 deletion lib-debug/binary_carrier.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib-debug/binary_carrier.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/binary_carrier.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/binary_carrier.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/binary_carrier.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
*/
export default class BinaryCarrier {
constructor(binaryData) {
this._buffer = binaryData;
this.buffer = binaryData;
}
}
9 changes: 9 additions & 0 deletions test/opentracing_api.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,14 @@ module.exports = function opentracingAPITests() {
expect(ref).to.be.an('object');
});
});


describe('BinaryCarrier', function() {
it('should set binary data as a field called "buffer"', function() {
var buffer = new Float64Array();
var ref = new opentracing.BinaryCarrier(buffer);
expect(ref.buffer).to.equal(buffer);
});
});
});
}