Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Added the mock_tracer to the opentracing export #90

Closed
wants to merge 1 commit into from

Conversation

jhorowitz
Copy link
Contributor

@jhorowitz jhorowitz commented Nov 30, 2017

In reference to #89

@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage decreased (-26.8%) to 62.025% when pulling a76dc51 on jhorowitz:testing/mock into 1f32ae4 on opentracing:master.

@yurishkuro
Copy link
Member

don't know why the build is failing.

is it possible to have a unit test that relies on the new import?

@jhorowitz
Copy link
Contributor Author

I'm not sure what you mean. Do you mean write unit tests for mock_tracer or fool the coverage so the build works? I'm planning on writing unit tests for mock_tracer but I don't have enough bandwidth to do that today.

@yurishkuro
Copy link
Member

I restarted the build, let's see if it succeeds. master branch is green, so no reason it shouldn't work in this PR.

What I meant by the import is if you look at #91 (comment) the import is done as import { MockTracer } from '../mock_tracer'; Instead is should be doing the import via ../index using the change from this PR.

@jhorowitz
Copy link
Contributor Author

I see. I'll tackle this on Monday

@yurishkuro
Copy link
Member

Done in #98

@yurishkuro yurishkuro closed this Feb 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants