Add rubocop #27
Merged
Add rubocop #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hasn't been enforced and includes a lot of noise.
Rubocop can be manually run by using `rake rubocop`, but it is also integrated into regular `rake` command which runs rubocop, tests and coverage. This should help keep this project code more consistent. I tried to use minimal set of rubocop rules and rely mostly on rubocop defaults.
|
/cc @itsderek23 |
This forces the build to also run rubocop.
mwear
approved these changes
Apr 10, 2018
There was a problem hiding this comment.
I'm not particularly tied to any specific style guidelines, but I do agree that consistency is important, especially for an open source project. The rubocop defaults work for me. Thanks for setting this up!
@itsderek23 do you have any thoughts on this?
I agree with this. I've gone ahead and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop can be manually run by using
rake rubocop, but it is also integratedinto regular
rakecommand which runs rubocop, tests and coverage.This should help keep this project code more consistent.
I tried to use minimal set of rubocop rules and rely mostly on rubocop
defaults.