Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version dependencies / Release 0.4.3 #40

Merged
merged 2 commits into from
Oct 24, 2018

Conversation

mwear
Copy link
Member

@mwear mwear commented Oct 24, 2018

While building the v0.4.2 gem release there were several warnings regarding open ended dependencies. For example:

WARNING:  open-ended dependency on simplecov (>= 0, development) is not recommended
  if simplecov is semantically versioned, use:
    add_development_dependency 'simplecov', '~> 0'
WARNING:  See http://guides.rubygems.org/specification-reference/ for help

My first attempt to fix this issue was e588d96 which was released as 0.4.2. Unfortunately, the bundler versioning broke the [build](https://travis-ci.org/opentracing/opentracing-ruby/builds/444695333. While there isn't technically anything wrong with the ruby code, the officially released gem should have a passing build.

I think it's probably overkill to yank 0.4.2, but I'd like to release this as 0.4.3. Do these changes look ok and does the release plan sound reasonable to everyone?

cc: @indrekj @itsderek23

@mwear mwear merged commit 0eed406 into opentracing:master Oct 24, 2018
@mwear mwear deleted the version_dependencies branch October 24, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants