New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Store profiles in user's home directory #179
Comments
Some MSVC 2015RC bug with static initialized const char*. But reproduced also in #179 (?)
The software doesn't delete files on its own. We should default to Documents/opentrack-VERSION but it's not a bug. |
But I only replaced the newer files, or did I accidentally overwrite the settings with that? Because always when I load up settings for your program within your program, I see files which I don't see when I manually browse to that location. How and where are the profiles organized? |
The full pathname to the used profile is stored in registry. Other settings are loaded that are in the same directory. You probably have an issue with file/directory permissions. We should definitely store in hardcoded document location, replace "open" with "copy" and allow for opening that directory from the main UI. |
What can we do about portable installations then? Look for is-portable.txt and then force the directory to be "install/settings/" instead of user's documents path? |
Yeah maybe? Don't know how many use it portable when the app has a real installer. |
Settings files are now stored in Documents/opentrack-version. The transition path is to copy all .ini files into that directory, accessible through the "Profile" menu dropdown. Issue: #179
We still need to refresh the config list automagically. |
Done, awaiting feedback |
I noticed that on the mapping screen, in RC17, that Yaw and Pitch default to Asymetric being checked. If I uncheck them the info is not being saved, when I stop and re-start they default back to them being checked. Not sure if this info is in the config file or not. Also, no option to save current profile - I assume it is now done automatically? |
I'm working on fixing the bug. Does the first of your profiles contain asymmetric yaw and pitch? It's getting pulled from somewhere. |
I think they were. Forgot I had set them in that profile. But, in RC17, if I uncheck them the change is not being saved. I'm not sure how the auto-save works. If I load the default.ini and makes some changes they are automatically written to the ini file, effectively modifying the default settings? If that is the case wouldn't it be better to be able to load an ini, modify it, and then do a save as to preserve the original ini file settings? I may be missing something here... |
Okay, started from scratch w/RC17 using the default.ini file. During the course of setting opentrack up the default.ini file was modified automatically each time I made a change. To me, a default file should not be modified, it should exist soley as a baseline and to return the program to default settings. Tracking is smooth as silk using a PS3 eye cam. I have noticed that when I return my view to the center that my view in the game, IL2 BOS, stays slightly off-center, both in yaw and pitch, roll is disabled. I've tried adjusting the mapping dead-zone, and the rotation dead-zone and sensitivity w/o any luck. Any thoughts? Also just noticed that after exiting and re-starting the default.ini is loaded and my settings are intact except it defaults the tracker to aruco. |
@Len62 I've run into the config issues as well. Please check rc17p1 if they still occur. As for default non-empty config we have no notion of immutable empty configs for now. For the off-center thing you might have a filtering deadzone set. Try reducing it. |
RC17p1 config issues are all working OK. Thanks! Not sure how I fixed the off-center issue but I think it may have been a setting in the game config. |
Great to hear that. Thanks! |
Are there any more issues remaining, guys? |
I don't have any. |
I seem to be having some kind of config write issue, ONLY in the test build you sent me, sthalik. First I start tracking, then stop. I then go to select a different input/protocol/filter (not change their sub-settings). When I press "Start" again, the protocol or filter will reset to the previous selection. Restarting the program will usually allow me to select a new input/protocol/filter, but even that is somewhat inconsistent. This doesn't seem to happen in rc17p2, but I believe the test build is newer (rc17p2-8-g22bde7a) so I thought you should know this issue was showing up. It's very minor as those settings are hardly changed after initially setting up a profile, so it really isn't hurting anyone. It might not even be reproducible in the most current build, but I wanted to let you know anyway. |
Yes, I've run into the same issue. Here's the latest version though: https://www.dropbox.com/s/gzhdm9ooge875gg/opentrack-test-20150901.7z Please confirm the issues are gone, and if there are other ones. |
Issue where it resets on pressing "Start" is fixed, but it now often resets when pressing "Stop." |
@nanospork it shouldn't. There's no "load settings" code in stop handler whatsoever. Note that saving settings to a file on disk is delayed by five seconds from the last change. Is this the culprit? It should be changed then. |
Note that if changing settings isn't delayed, it might take up to half a second after every change to save the main ui's settings. There's visible lag and delay between switching trackers. |
I'll look into it regardless, but please confirm. |
Yes, it looks like if I wait 5 seconds the setting remains as it should. If I change a setting and then press "stop" within five seconds, it reverts. Perhaps "stop" is interrupting the save? Also, by your description, seems like the 5 seconds is worth it to avoid the lag. So the behavior I'm experiencing is really a non-issue. |
It is an issue. It's a pretty serious bug actually. I can reproduce 'stop' bug. |
Force saving when tracking is stopping at least. Due to "struct work" being destroyed, unsaved settings revert to last saved. So before "struct work" destruction need to save if save is pending. Issue: #179
With the last commit It looks fixed. On stopping tracking, it's saved immediately if there is save timer pending. Thanks for finding this obscure case @nanospork. |
I always put the new files of your software in the folder of the current folder and replace every file. Normally the settings were intact, but now every profile is gone and only the default profile shows up. Is this by design or is this a bug somehow? By the way wouldn't it be better if the settings were put in the userfolder instead of writing settings in the regular install location?
The text was updated successfully, but these errors were encountered: