Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octopus having artifacts at specific settings #356

Closed
MathijsG opened this issue May 13, 2016 · 7 comments
Closed

Octopus having artifacts at specific settings #356

MathijsG opened this issue May 13, 2016 · 7 comments

Comments

@MathijsG
Copy link
Contributor

On specific settings here, being 90 degrees pitch in-game, and the last position before 20 degrees in physical, my octopus is tripping all over.

I've made a video of it: https://www.youtube.com/watch?v=9y9I5DdqR9s

As far as I see it doesn't affect the output, however this effect seems weird to me.
@sthalik
Copy link
Member

sthalik commented May 13, 2016

Good catch on reproducing it. I'll take a look.

sthalik added a commit that referenced this issue May 13, 2016
@sthalik
pose-widget: avoid too small denominator in perpendicular alignment
ee18bc0 
With a very small denominator in barycentric coords formula we get a
dissociated octopus that took PCP and LSD in one sitting.

A dead Octopus is just a bunch of blue spheres.

IOW, in division with too small a denominator operand the results are
numerically unstable.

This is done in the constructor in a convoluted way as to avoid
branching during calculating for each pixel.

Issue: #356
Reported-by: @MathijsG
@sthalik
Copy link
Member

sthalik commented May 13, 2016

@MathijsG please confirm fixed https://www.dropbox.com/s/rsj78idet70clqt/opentrack-pt-v15.7z

@MathijsG
Copy link
Contributor Author

Still having the issue? is your upload the correct one? It's not stating some like V15.

image

sthalik added a commit that referenced this issue May 14, 2016
@sthalik
pose-widget: try harder to avoid small denominator
d619859 
Previous commit fixed only the case with one perpendicular axis of
rotation with the rest fixed at origin. This one works with all three
degrees of freedom enabled.

Reported-by: @MathijsG
Issue: #356
@sthalik
Copy link
Member

sthalik commented May 14, 2016

@MathijsG please try https://www.dropbox.com/s/krt76r4zp2owkc5/opentrack-pt-v16.7z

It works for me with yaw, pitch, and raw all enabled. The archive naming is arbitrary.

@MathijsG
Copy link
Contributor Author

Working here now! Great work man!

Was this problem introduced by something recently? I can't remember having this weirdness earlier on.

@sthalik
Copy link
Member

sthalik commented May 14, 2016

@MathijsG probably not. But even if, the numerical code has to remain stable in light of recent changes. There's a new flag for vectorization now but the thing I fear here is crashes on just some CPUs.

@sthalik
Copy link
Member

sthalik commented May 14, 2016

@MathijsG and thanks for the amount of work you put into submitting and discussing issues during the whole 2.3 development process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MathijsG @sthalik