Tidy/ewma2 #1
Merged
Tidy/ewma2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sthalik
pushed a commit
that referenced
this pull request
Sep 30, 2023
Formatting corrections and minor revisions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a completely behavior neutral tidyup and optimization of the ewma2 filter. It just tidies up mixed tab/space indenting, and removes a bunch of redundant data copying.
It should behave exactly the same as the existing ewma2 filter, but it should be a tiny bit more efficient.
Apologies for the messy merge history... suggestions on how to fix and/or avoid this in the future are welcome.