Apply dark theme on Windows if user enabled it in system settings. #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I would like to have dark mode because I can see for example the opentrack on second screen while playing game. The light mode glows a little bit to bright. You could provide a simple .xml file with color properties and we, the users, will do the rest 👍 |
sthalik
requested changes
Sep 18, 2020
gui/init.cpp
Outdated
| @@ -269,6 +269,38 @@ int otr_main(int argc, char** argv, std::function<std::unique_ptr<QWidget>()> co | |||
|
|
|||
| QApplication app(argc, argv); | |||
|
|
|||
| #ifdef Q_OS_WIN | |||
There was a problem hiding this comment.
Use #ifdef _WIN32. Put in its own function, like maybe_apply_dark_windows_theme(). Confirm that mapping widget works.
Slion
force-pushed
the
feature_windows_dark_theme
branch
from
32409ba
to
32c8c82
Compare
|
LGTM. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.