Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple airports with the same IATA code active at the same time #17

Closed
wsteitz opened this issue Mar 13, 2016 · 2 comments
Closed

multiple airports with the same IATA code active at the same time #17

wsteitz opened this issue Mar 13, 2016 · 2 comments
Assignees
Labels

Comments

@wsteitz
Copy link
Member

wsteitz commented Mar 13, 2016

Sometimes IATA airport codes are reused. But at any point in time, the IATA codes of active airports should be unique. Looking at optd_por_public.csv, this is currently not the case. The date_from/date_to dates seem to be incomplete.

These IATA codes can be detected with a python script: https://gist.github.com/wsteitz/0905c749b6b811e1df75

The output of the script:
MZA 1900-01-01 to 2012-09-01 and 1900-01-01 to 2999-12-31
YGS 1900-01-01 to 2013-09-01 and 1900-01-01 to 2013-09-01
MHC 1900-01-01 to 2012-01-01 and 1900-01-01 to 2999-12-31
NAT 1900-01-01 to 2014-06-01 and 1900-01-01 to 2999-12-31
SHO 1900-01-01 to 2012-12-14 and 1900-01-01 to 2999-12-31

@wsteitz wsteitz self-assigned this Mar 13, 2016
@da115115
Copy link
Member

The Python script has been (amended and) added to the Quality Assurance (QA) tests of the Service Delivery Quality (SDQ) project.
Current output of that check:

{'geonames_id': '5960660', 'location_type': 'CA', 'date_from': '1900-01-01', 'date_until': '2013-09-01', 'env_id': '1', 'country_code': 'CA', 'por_code': 'YGS'}
{'geonames_id': '11001159', 'location_type': 'A', 'date_from': '1900-01-01', 'date_until': '2999-12-31', 'env_id': '', 'country_code': 'PE', 'por_code': 'MZA'}
{'geonames_id': '3406959', 'location_type': 'A', 'date_from': '1900-01-01', 'date_until': '2014-06-01', 'env_id': '1', 'country_code': 'BR', 'por_code': 'NAT'}
{'geonames_id': '8521372', 'location_type': 'A', 'date_from': '1900-01-01', 'date_until': '2999-12-31', 'env_id': '', 'country_code': 'SZ', 'por_code': 'SHO'}
{'geonames_id': '8410843', 'location_type': 'A', 'date_from': '1900-01-01', 'date_until': '2999-12-31', 'env_id': '', 'country_code': 'CL', 'por_code': 'MHC'}

@wsteitz
Copy link
Member Author

wsteitz commented Mar 30, 2016

no more overlaps!

@wsteitz wsteitz closed this as completed Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants