[#622] Fix flash notifications not being discarded

There was an issue with the `yar` plugin being registered by Glue before the
extension function, thus leading to weird interferences with the session store.

Moved it to `lib/plugins/yar` and registered in `server.js` right after the
extensions.

Fixes #622

assets/styles/ot-scss/_flash-messages.scss

@@ -1,4 +1,6 @@
 .flash-message {
+  list-style: none;
+  padding: 0;
   position: fixed;
   top: 0;
   width: 100%;

config/glue.js

@@ -89,21 +89,6 @@ const manifest = {
         select: ['web', 'web-fda'],
       },
     },
-    {
-      plugin: {
-        register: 'yar',
-        options: {
-          storeBlank: false,
-          cookieOptions: {
-            password: process.env.SESSION_PASSWORD,
-            isSecure: false,  // FIXME: Set to true in production when issue #100 is fixed
-          },
-        },
-      },
-      options: {
-        select: ['web', 'web-fda'],
-      },
-    },
   ],
 };
 

lib/plugins.js

@@ -8,6 +8,7 @@ const plugins = {
   httpErrorHandler: require('./plugins/http-error-handler'),
   sendErrorsToSentry: require('./plugins/send-errors-to-sentry'),
   sendEmail: require('./plugins/send-email'),
+  yar: require('./plugins/yar'),
 };
 
 module.exports = plugins;

lib/plugins/yar.js

@@ -0,0 +1,14 @@
+'use strict';
+
+const register = {
+  register: require('yar'),
+  options: {
+    storeBlank: false,
+    cookieOptions: {
+      password: process.env.SESSION_PASSWORD,
+      isSecure: false,  // FIXME: Set to true in production when issue #100 is fixed
+    },
+  },
+};
+
+module.exports = register;

server.js

@@ -36,6 +36,10 @@ function startOrInitializeServer(resolve, reject) {
       server.ext('onPreResponse', plugins.addCurrentURLToContext);
       server.ext('onPreResponse', plugins.httpErrorHandler);
 
+      // `yar` registration needs to happen after registering `addFlashMessagesToContext`
+      // and Glue does not allow anything related to `server.ext`
+      server.register(plugins.yar);
+
       server.views(config.hapi.views);
 
       return server.initialize()