Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for transfer rules is slow #2078

Closed
mattwigway opened this issue Aug 3, 2015 · 3 comments
Closed

Searching for transfer rules is slow #2078

mattwigway opened this issue Aug 3, 2015 · 3 comments

Comments

@mattwigway
Copy link
Member

Searching for transfer rules in RaptorWorkerTimetable::getFrequencyDeparture is close to 70% of runtime on pure-frequency networks. Looks like this is largely due to stream creation.

@abyrd
Copy link
Member

abyrd commented Aug 3, 2015

Does this optimization significantly improve runtime? If so, then we have to rethink using Java 8 features.

@mattwigway
Copy link
Member Author

Yes, at least when the lists are empty, not constructing the empty streams saves several seconds per request.

Matthew Wigginton Conway
Transportation Analytics/Open Source
Washington, DC
indicatrix.org

---- On Mon, 03 Aug 2015 19:01:06 -0400 Andrew Byrd <notifications@github.com> wrote ----

Does this optimization significantly improve runtime? If so, then we have to rethink using Java 8 features.

Reply to this email directly or view it on GitHub.

@mattwigway
Copy link
Member Author

I should add that this function is called millions of times per request and usually does nothing. This is a particular use case (constructing lots of empty streams) that probably isn't common.

flibbertigibbet pushed a commit to flibbertigibbet/OpenTripPlanner that referenced this issue Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants