Underscores stripped out of feed IDs

[abyrd]

Giuseppe on the mailing list reports:
"I noted that if the feed id is given by the concatenation by underscore of two words, the program drops the underscore, CHINA_RAIL becomes CHINARAIL."

[johannilsson]

This was made as a workaround for OBA that split ids on underscores, OTP splits on colon which is also stripped from the id.

This is done here, https://github.com/opentripplanner/OpenTripPlanner/blob/master/src/main/java/org/opentripplanner/graph_builder/module/GtfsFeedId.java#L99

[abyrd]

Thanks @johannilsson, I see this was added in b5ae935. I don't fully understand though why OTP needs to clean IDs to match OBA conventions. Can you give some more context?

[johannilsson]

AgencyAndId.convertFromString is used in RoutingResource, this assumes the separator is an underscore. This seems fairly easy to refactor though, I can't remember if there was other parts that required this change as well though. Can do a tests on our builds without replacing the underscore to see how it works.

[abyrd]

Oh I see, it's because we're using OBA as a library and it obeys this convention.

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days