Migrate to Java 11 (porting PR #2812, plus a few small changes) #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports PR #2812 over to 2.x as a single commit.
Oracle documentation shows line breaks as p tags with no slash: http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#format
This eliminates Maven warnings. Arguably we might want Javadoc linting on, but it was already switched off using a different parameter for an older Javadoc plugin version.
Also exclude a problematic package from javadocs.
|
As mentioned in #2812 (comment) I have simplified this PR by removing module-info.java entirely, and just specifying |
t2gran
approved these changes
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is porting over pull request #2812, so should only be approved and merged once that other PR is merged into dev-1.x.
I added a couple of commits above what was in the original PR and will suggest that those additional commits may be cherry-picked over to 1.x.