Add support for GBFS auto discovery of endpoints #3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 12, 2021 12:23
- Turn floating bike support off by default - Document why floating bike support is turned off
…_realtime_update Fix bug in TransitLayerUpdater
t2gran
reviewed
Jan 19, 2021
src/main/java/org/opentripplanner/updater/bike_rental/datasources/GbfsBikeRentalDataSource.java
Outdated
Show resolved
Hide resolved
t2gran
reviewed
Jan 19, 2021
t2gran
reviewed
Jan 19, 2021
src/main/java/org/opentripplanner/updater/bike_rental/datasources/GbfsBikeRentalDataSource.java
Outdated
Show resolved
Hide resolved
…_type Add FlexibleLineType as pass-through field on Route
…one line - code guideline.
OTP2 Development
automation
moved this from In progress (PRs)
to Review in progress (PRs)
Jan 19, 2021
t2gran
requested changes
Jan 19, 2021
| @@ -80,6 +80,8 @@ public GenericJsonBikeRentalDataSource() { | |||
|
|
|||
| @Override | |||
| public boolean update() { | |||
| if (url == null) return false; | |||
There was a problem hiding this comment.
Missing {}: if (url == null) { return false; }
t2gran
approved these changes
Jan 19, 2021
Add support for GBFS auto discovery of endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be completed by pull request submitter:
To be completed by @opentripplanner/plc:
This PR adds support for GBFS auto discovery of endpoints, which brings the updater closer to GBFS 2.1 compatibility. It also turns off floating bike support by default, as it is contains a memory leak and is not safe to use.