Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading cached elevation files #3455

Merged
merged 3 commits into from May 4, 2021

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented May 4, 2021

When trying out the cached elevation file feature introduced by @evansiroky a while back, the following exception stopped my graph build.

java.util.UnknownFormatConversionException: Conversion = ')'
         at java.base/java.util.Formatter.checkText(Formatter.java:2732) ~[na:na]
         at java.base/java.util.Formatter.parse(Formatter.java:2718) ~[na:na]
         at java.base/java.util.Formatter.format(Formatter.java:2655) ~[na:na]
         at java.base/java.util.Formatter.format(Formatter.java:2609) ~[na:na]
         at java.base/java.lang.String.format(String.java:2897) ~[na:na]
         at org.opentripplanner.graph_builder.issues.Graphwide.getMessage(Graphwide.java:15) ~[otp-shaded.jar:1.1]
         at org.opentripplanner.graph_builder.DataImportIssueStore.add(DataImportIssueStore.java:24) ~[otp-shaded.jar:1.1]
         at org.opentripplanner.graph_builder.module.ned.ElevationModule.buildGraph(ElevationModule.java:226) ~[otp-shaded.jar:1.1]
         at org.opentripplanner.graph_builder.GraphBuilder.run(GraphBuilder.java:80) ~[otp-shaded.jar:1.1]
         at org.opentripplanner.standalone.OTPMain.startOTPServer(OTPMain.java:136) ~[otp-shaded.jar:1.1]
         at org.opentripplanner.standalone.OTPMain.main(OTPMain.java:52) ~[otp-shaded.jar:1.1]

String.format is running into trouble however that function is totally unnecessary and can be removed without replacement.

Changelog

Added.

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner May 4, 2021 12:53
gmellemstrand
gmellemstrand previously approved these changes May 4, 2021
@gmellemstrand gmellemstrand merged commit 1a7f790 into opentripplanner:dev-2.x May 4, 2021
@t2gran t2gran added this to the 2.1 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants