Skip to content

Fix reading cached elevation files#3455

Merged
gmellemstrand merged 3 commits into
opentripplanner:dev-2.xfrom
mfdz:cached-elevation-fix
May 4, 2021
Merged

Fix reading cached elevation files#3455
gmellemstrand merged 3 commits into
opentripplanner:dev-2.xfrom
mfdz:cached-elevation-fix

Conversation

@leonardehrenfried

@leonardehrenfried leonardehrenfried commented May 4, 2021

Copy link
Copy Markdown
Member

When trying out the cached elevation file feature introduced by @evansiroky a while back, the following exception stopped my graph build.

java.util.UnknownFormatConversionException: Conversion = ')'
         at java.base/java.util.Formatter.checkText(Formatter.java:2732) ~[na:na]
         at java.base/java.util.Formatter.parse(Formatter.java:2718) ~[na:na]
         at java.base/java.util.Formatter.format(Formatter.java:2655) ~[na:na]
         at java.base/java.util.Formatter.format(Formatter.java:2609) ~[na:na]
         at java.base/java.lang.String.format(String.java:2897) ~[na:na]
         at org.opentripplanner.graph_builder.issues.Graphwide.getMessage(Graphwide.java:15) ~[otp-shaded.jar:1.1]
         at org.opentripplanner.graph_builder.DataImportIssueStore.add(DataImportIssueStore.java:24) ~[otp-shaded.jar:1.1]
         at org.opentripplanner.graph_builder.module.ned.ElevationModule.buildGraph(ElevationModule.java:226) ~[otp-shaded.jar:1.1]
         at org.opentripplanner.graph_builder.GraphBuilder.run(GraphBuilder.java:80) ~[otp-shaded.jar:1.1]
         at org.opentripplanner.standalone.OTPMain.startOTPServer(OTPMain.java:136) ~[otp-shaded.jar:1.1]
         at org.opentripplanner.standalone.OTPMain.main(OTPMain.java:52) ~[otp-shaded.jar:1.1]

String.format is running into trouble however that function is totally unnecessary and can be removed without replacement.

Changelog

Added.

@leonardehrenfried
leonardehrenfried requested a review from a team May 4, 2021 12:53
gmellemstrand
gmellemstrand previously approved these changes May 4, 2021
@gmellemstrand
gmellemstrand merged commit 1a7f790 into opentripplanner:dev-2.x May 4, 2021
@t2gran t2gran added this to the 2.1 milestone May 11, 2021
@leonardehrenfried
leonardehrenfried deleted the cached-elevation-fix branch December 10, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants