Rename bike rental vehicle rental in internal classes #3595
Conversation
…TripPlanner into dev-2.x
|
I tried this PR with the data from our region and I can confirm that it still works.
|
| @@ -42,7 +42,7 @@ | |||
| - Do not allow bicycle traversal on ways tagged with mtb:scale [#3578](https://github.com/opentripplanner/OpenTripPlanner/pull/3578) | |||
| - Changes to the StopTimes call [#3576](https://github.com/opentripplanner/OpenTripPlanner/issues/3576) | |||
| - Fix bug in optimize transfer service decorating path [#3587](https://github.com/opentripplanner/OpenTripPlanner/issues/3587) | |||
|
|
|||
| - Remove non-GBFS bicycle rental updaters [#3562](https://github.com/opentripplanner/OpenTripPlanner/issues/3562) | |||
There was a problem hiding this comment.
FYI, we usually try to have 2 blank lines above a header and 1 blank line below. No need to fix this, we will insert an extra line next time around.
There was a problem hiding this comment.
This needed fixing anyway due to merge conflict
| @@ -1,35 +1,37 @@ | |||
| package org.opentripplanner.routing.bike_rental; | |||
| package org.opentripplanner.routing.vehicle_rental; | |||
There was a problem hiding this comment.
Strictly using a _ in the package name is not recommended, but I think it is much more readable than not. We should probably make an exception for this in the coding guideline. I am in favor of keeping the ´_´ here.
|
We will wait for @leonardehrenfried to do a smoke test on this before merging, just to be safe. |
hannesj
dismissed stale reviews from t2gran and leonardehrenfried
via
e2079f6
I think this was already confirmed here #3595 |
|
Yes, I confirmed that they work upthread. @hannesj What you see now is the snapshot tests failing. You want to delete the snapshot files and rerun the tests to regenerate them. After that you can check the JSON for unexpected changes. |
Note that the snapshot tests compare the internal model, not API classes, which were unchanged.
…ntur/OpenTripPlanner into otp2_bike_rental_vehicle_rental_rename
Summary
This PR renames bike rental to vehicle rental in internal classes. This change is meant to reduce the mental overhead, as the classes support other types of vehicles, like cars and micromobility vehicles. It is based on top of #3562 and #3568.
Issue
Relates to #2778 and MobilityData/gbfs#354
Unit tests
Pure refactoring, existing tests pass
Documentation
Changelog
Was a bullet point added to the changelog file with description and link to the linked issue?