Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NeTEx VIA's #3883

Merged
merged 1 commit into from Feb 19, 2022
Merged

Add support for NeTEx VIA's #3883

merged 1 commit into from Feb 19, 2022

Conversation

Bartosz-Kruba
Copy link
Contributor

@Bartosz-Kruba Bartosz-Kruba commented Feb 9, 2022 •
edited

Summary

Support for NeTEx via's (with transmodel GraphQL API). According to Transmodel Documentation.

Issue

#3886

Unit tests

  • New unit tests inside src/test/java/org/opentripplanner/routing/trippattern/DeduplicatorTest.java
  • New unit tests inside src/test/java/org/opentripplanner/netex/mapping/StopTimesMapperTest.java

Code style

Follows recommended code style.

Documentation

  • Added Java docs for new methods.

@Bartosz-Kruba Bartosz-Kruba changed the title Add support for NeTEx via to StopTimeMapper Add support for NeTEx VIA's Feb 9, 2022
@Bartosz-Kruba Bartosz-Kruba marked this pull request as ready for review February 9, 2022 16:13
@Bartosz-Kruba Bartosz-Kruba requested a review from a team as a code owner February 9, 2022 16:13
@MikaelJarfors MikaelJarfors added the Skanetrafiken On skanetrafikens roadmap label Feb 10, 2022
@t2gran t2gran added this to the 2.1 milestone Feb 10, 2022
@hannesj hannesj self-requested a review February 10, 2022 14:53
t2gran
t2gran previously approved these changes Feb 10, 2022
View reviewed changes
@t2gran t2gran dismissed their stale review February 10, 2022 15:05

I need to take another look at this, I missed the change in TripTimes

@t2gran t2gran self-requested a review February 17, 2022 14:11
@t2gran t2gran merged commit a8823b0 into opentripplanner:dev-2.x Feb 19, 2022
t2gran pushed a commit that referenced this pull request Feb 19, 2022
Add changelog entry for #3883 [ci skip]
786e70d
@hannesj hannesj mentioned this pull request Mar 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannesj hannesj hannesj approved these changes

@t2gran t2gran t2gran approved these changes

Assignees
No one assigned
Labels
Skanetrafiken On skanetrafikens roadmap
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bartosz-Kruba @hannesj @t2gran @MikaelJarfors