Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for groupOfLines in top level Transmodel API [changelog skip] #4232

Merged
merged 2 commits into from Jun 22, 2022

Conversation

hannesj
Copy link
Contributor

@hannesj hannesj commented Jun 22, 2022

Summary

Add support for groupOfLines in top level Transmodel API, both for querying a single and all groups. Also, add possibility to fetch all lines part of a group.

@hannesj hannesj added improvement sandbox Entur test This is currently being tested at Entur labels Jun 22, 2022
@hannesj hannesj added this to the 2.2 milestone Jun 22, 2022
@hannesj hannesj requested a review from t2gran June 22, 2022 07:02
@hannesj hannesj requested a review from a team as a code owner June 22, 2022 07:02
Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though you still have to merge with master, I will approve this.

@codecov-commenter
Copy link

Codecov Report

Merging #4232 (8fa8b7c) into dev-2.x (deb53dc) will decrease coverage by 0.00%.
The diff coverage is 65.90%.

@@              Coverage Diff              @@
##             dev-2.x    #4232      +/-   ##
=============================================
- Coverage      56.63%   56.63%   -0.01%     
+ Complexity     10509    10507       -2     
=============================================
  Files           1398     1398              
  Lines          57107    57150      +43     
  Branches        6645     6647       +2     
=============================================
+ Hits           32344    32366      +22     
- Misses         22744    22763      +19     
- Partials        2019     2021       +2     
Impacted Files Coverage Δ
...planner/transit/service/DefaultTransitService.java 24.67% <0.00%> (-1.01%) ⬇️
.../org/opentripplanner/routing/graph/GraphIndex.java 76.08% <30.00%> (-4.39%) ⬇️
...ner/ext/transmodelapi/TransmodelGraphQLSchema.java 65.81% <82.60%> (+0.49%) ⬆️
.../transmodelapi/model/network/GroupOfLinesType.java 95.83% <87.50%> (-1.67%) ⬇️
...g/opentripplanner/api/parameter/QualifiedMode.java 65.78% <0.00%> (-2.64%) ⬇️
...ph_builder/module/ned/MissingElevationHandler.java 93.70% <0.00%> (-1.58%) ⬇️
...pplanner/graph_builder/module/osm/OSMDatabase.java 76.73% <0.00%> (-0.94%) ⬇️
...aph_builder/module/OsmBoardingLocationsModule.java 71.69% <0.00%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb53dc...8fa8b7c. Read the comment docs.

@MikaelJarfors MikaelJarfors self-requested a review June 22, 2022 13:03
@hannesj hannesj merged commit 80971c8 into opentripplanner:dev-2.x Jun 22, 2022
@hannesj hannesj deleted the otp2-group-of-lines branch June 22, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entur test This is currently being tested at Entur improvement sandbox skip changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants