Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block-based interlining when importing several GTFS feeds #4468

Merged
merged 3 commits into from Sep 27, 2022

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Sep 23, 2022

Summary

When importing several GTFS feeds where one of them uses block-based interlining then all following imports regenerate the stay-seated transfers for all of the previous feeds. This leads to a huge number of constrained transfers which is terrible for performance.

Issue

Fixes #4467.

Unit tests

Test added.

@leonardehrenfried leonardehrenfried added bug GTFS Related to import of GTFS data optimization The feature is to improve performance. IBI Developed by or important for IBI Group labels Sep 23, 2022
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner September 23, 2022 11:48
@codecov-commenter
Copy link

Codecov Report

Base: 58.47% // Head: 58.47% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1683c6e) compared to base (e7aa8a8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4468      +/-   ##
=============================================
- Coverage      58.47%   58.47%   -0.01%     
+ Complexity     11430    11429       -1     
=============================================
  Files           1512     1512              
  Lines          60101    60101              
  Branches        6829     6829              
=============================================
- Hits           35146    35145       -1     
  Misses         22894    22894              
- Partials        2061     2062       +1     
Impacted Files Coverage Δ
...entripplanner/graph_builder/module/GtfsModule.java 71.03% <100.00%> (ø)
...g/opentripplanner/api/parameter/QualifiedMode.java 65.78% <0.00%> (-2.64%) ⬇️
...pplanner/graph_builder/module/osm/OSMDatabase.java 76.14% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@t2gran t2gran added this to the 2.2 milestone Sep 27, 2022
@leonardehrenfried leonardehrenfried merged commit 9ae04cf into opentripplanner:dev-2.x Sep 27, 2022
@leonardehrenfried leonardehrenfried deleted the fix-interlining branch September 27, 2022 09:20
t2gran pushed a commit that referenced this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug GTFS Related to import of GTFS data IBI Developed by or important for IBI Group optimization The feature is to improve performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block-based interlining leads to an excessive number of stay-seated transfers
5 participants