Enable fuzzyTripMatching in other SIRI-ET updaters - #4495
Merged
Conversation
hannesj
added
!Technical Debt
Codecov ReportBase: 58.60% // Head: 58.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4495 +/- ##
==========================================
Coverage 58.60% 58.60%
+ Complexity 11516 11513 -3
==========================================
Files 1517 1517
Lines 60538 60511 -27
Branches 6885 6884 -1
==========================================
- Hits 35478 35464 -14
+ Misses 22972 22961 -11
+ Partials 2088 2086 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Bartosz-Kruba
previously approved these changes
Oct 4, 2022
leonardehrenfried
previously approved these changes
Oct 4, 2022
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
I reviewed the non-sandbox code and it looks good.
lassetyr
previously approved these changes
Oct 6, 2022
Member
|
I'm afraid you need to resolve the conflicts with the metrics PR that I merged a few minutes ago. |
hannesj
dismissed stale reviews from lassetyr, leonardehrenfried, and Bartosz-Kruba
via
October 6, 2022 10:39
069cb34
leonardehrenfried
approved these changes
Oct 6, 2022
lassetyr
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #4347, the fuzzyTripMatching was set to false in all SIR-ET updaters-except in the Azure updater. This PR adds the config option to other SIRI-ET updater modules, and cleans up the implementation, so that a SiriFuzzyTripMatcher is created only when the config parameter is set to true. This required some clean-up of the matcher, which is included in the PR.