New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable fuzzyTripMatching in other SIRI-ET updaters #4495
Conversation
Codecov ReportBase: 58.60% // Head: 58.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4495 +/- ##
==========================================
Coverage 58.60% 58.60%
+ Complexity 11516 11513 -3
==========================================
Files 1517 1517
Lines 60538 60511 -27
Branches 6885 6884 -1
==========================================
- Hits 35478 35464 -14
+ Misses 22972 22961 -11
+ Partials 2088 2086 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the non-sandbox code and it looks good.
I'm afraid you need to resolve the conflicts with the metrics PR that I merged a few minutes ago. |
069cb34
Summary
After #4347, the fuzzyTripMatching was set to false in all SIR-ET updaters-except in the Azure updater. This PR adds the config option to other SIRI-ET updater modules, and cleans up the implementation, so that a SiriFuzzyTripMatcher is created only when the config parameter is set to true. This required some clean-up of the matcher, which is included in the PR.