Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary sourceType attribute from GTFS-RT configuration #4525

Merged

Conversation

leonardehrenfried
Copy link
Member

Summary

In #4517 the field configType for GTFS-RT updaters was changed leading to users having to update their config files. This led me to investigate if the field is actually necessary and it turns out that it isn't!

Removing this field resolves a couple of long standing TODOs and will make configuration easier.

Documentation

Updated.

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner October 16, 2022 07:00
@leonardehrenfried leonardehrenfried changed the title Remove unnecessary sourceType attribute from GTFS-RT documentation Remove unnecessary sourceType attribute from GTFS-RT configuration Oct 16, 2022
@leonardehrenfried leonardehrenfried added RealTimeUpdate The issue/PR is related to RealTime updates config change labels Oct 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Base: 59.70% // Head: 59.69% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d003da2) compared to base (14a9659).
Patch coverage: 18.18% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4525      +/-   ##
=============================================
- Coverage      59.70%   59.69%   -0.01%     
  Complexity     11881    11881              
=============================================
  Files           1556     1556              
  Lines          62390    62371      -19     
  Branches        6966     6966              
=============================================
- Hits           37252    37235      -17     
+ Misses         22988    22987       -1     
+ Partials        2150     2149       -1     
Impacted Files Coverage Δ
...pentripplanner/ext/siri/updater/SiriETUpdater.java 0.00% <ø> (ø)
...pentripplanner/ext/siri/updater/SiriVMUpdater.java 0.00% <ø> (ø)
.../config/updaters/PollingStoptimeUpdaterConfig.java 63.15% <0.00%> (-10.76%) ⬇️
...va/org/opentripplanner/updater/DataSourceType.java 100.00% <ø> (ø)
...entripplanner/updater/trip/PollingTripUpdater.java 0.00% <0.00%> (ø)
...ner/updater/trip/PollingTripUpdaterParameters.java 47.82% <ø> (+1.67%) ⬆️
...ehicle_position/PollingVehiclePositionUpdater.java 0.00% <ø> (ø)
...config/updaters/VehiclePositionsUpdaterConfig.java 88.88% <100.00%> (+4.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leonardehrenfried leonardehrenfried merged commit c8f38ca into opentripplanner:dev-2.x Oct 17, 2022
t2gran pushed a commit that referenced this pull request Oct 17, 2022
@leonardehrenfried leonardehrenfried deleted the remove-source-type branch October 17, 2022 10:44
@t2gran t2gran added this to the 2.2 milestone Oct 25, 2022
@leonardehrenfried leonardehrenfried added the IBI Developed by or important for IBI Group label Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config change IBI Developed by or important for IBI Group RealTimeUpdate The issue/PR is related to RealTime updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants