Add Fares v2 to GraphQL API #4917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
added
improvement
sandbox
IBI
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4917 +/- ##
=============================================
+ Coverage 64.46% 64.58% +0.11%
- Complexity 13896 13937 +41
=============================================
Files 1721 1725 +4
Lines 67229 67355 +126
Branches 7214 7218 +4
=============================================
+ Hits 43339 43499 +160
+ Misses 21466 21435 -31
+ Partials 2424 2421 -3
☔ View full report in Codecov by Sentry. |
leonardehrenfried
force-pushed
the
fares-v2-graphql
branch
2 times, most recently
from
e588013
to
db108e5
Compare
t2gran
reviewed
Mar 3, 2023
src/main/java/org/opentripplanner/routing/core/IndexedLegProducts.java
Outdated
Show resolved
Hide resolved
leonardehrenfried
force-pushed
the
fares-v2-graphql
branch
9 times, most recently
from
80cf74a
to
c08be0f
Compare
leonardehrenfried
changed the title
leonardehrenfried
force-pushed
the
fares-v2-graphql
branch
5 times, most recently
from
d0f459f
to
1e38b14
Compare
vesameskanen
previously approved these changes
Apr 28, 2023
t2gran
requested changes
Apr 28, 2023
src/main/java/org/opentripplanner/model/plan/UnknownTransitPathLeg.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/routing/core/ItineraryFares.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/routing/core/ItineraryFares.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/routing/core/ItineraryFares.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/routing/core/ItineraryFares.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Gran <t2gran@gmail.com>
|
@vesameskanen has already approved this twice so I'm going wait to re-request a review until @t2gran has finished his review. |
t2gran
reviewed
May 2, 2023
|
I am done with my review now. I have not reviewed the classes inside the Sandbox and only done a technical review on the rest. I do not now the GTFS Fares spec so my review on the business logic is at best superficial. |
|
We discussed this in the dev meeting today and I've renamed |
t2gran
approved these changes
May 5, 2023
vesameskanen
approved these changes
May 8, 2023
t2gran
pushed a commit
that referenced
this pull request
May 8, 2023
This was referenced May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This one adds the new FaresV2 entities to the GraphQL API.
I would like to talk about the schema in the dev meeting if it is the right way to think about fares.
Closes #4935
Unit tests
Added.