Initialize RAPTOR stop-to-stop transfers on server startup #4977
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4977 +/- ##
=============================================
+ Coverage 64.08% 64.14% +0.06%
- Complexity 13593 13621 +28
=============================================
Files 1676 1676
Lines 66288 66456 +168
Branches 7154 7164 +10
=============================================
+ Hits 42480 42630 +150
- Misses 21429 21441 +12
- Partials 2379 2385 +6
... and 16 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
flaktack
force-pushed
the
feature/transfer-cache
branch
from
5aa48c8
to
a73a5c1
Compare
flaktack
force-pushed
the
feature/transfer-cache
branch
from
a73a5c1
to
6e0b3c4
Compare
This is required for transferCacheRequest items to use routingDefaults.
flaktack
force-pushed
the
feature/transfer-cache
branch
from
6e0b3c4
to
a95253a
Compare
|
@Bartosz-Kruba Since this is a feature that you're interested in, could you please review this? |
|
Can you please resolve the conflicts? |
| @@ -2,17 +2,17 @@ | |||
| "configVersion": "v2.2.0-EN000121", | |||
| "streetRoutingTimeout": "5s", | |||
| "routingDefaults": { | |||
| "walkSpeed": 1.3, | |||
| "walkSpeed": 1.33, | |||
There was a problem hiding this comment.
Are these configuration changes relevant to the implementation?
There was a problem hiding this comment.
I think we want these changes - look at it as clen-up, not relevant, but indeed welcome.
There was a problem hiding this comment.
It is required due to this change:
a95253a#diff-4694584dc4047e7a37434a4b1dcc131e4c40470f737bf21eb222b7180de2fdf8L61-R61
router-config.json is parsed when creating the documentation. Since the values in RouteRequest are now copied from the default request (due to using clone()) parsing transferCacheRequests modifies the stored default values for the documentation. routingDefaults was updated to the default values due to this.
There was a problem hiding this comment.
It seems the changes are not needed anymore, I've removed them.
…rConfiguration.md
Due to changes in the documentation generation these changes are not needed anymore.
src/test/java/org/opentripplanner/generate/doc/framework/SkipNodes.java
Outdated
Show resolved
Hide resolved
Summary
The runtime configuration is modified so that a list of
RouteRequests may be specified to calculate stop-to-stop transfers before the server is ready to serve requests.router-config.jsonis extended with a new field,transferCacheRequests. TheRouteRequestconfigured inroutingDefaultsis the default for the items intransferCacheRequests.transferCacheRequestsare used to initializeRaptorRequestTransferCache.{ "transit": { "transferCacheRequests": [ { "modes": "WALK" }, { "modes": "WALK", "wheelchairAccessibility": { "enabled": true } } ] } }Adding items to
transferCacheRequestsincreases the server startup time with considerable CPU usage. If automatic scaling is configured based on CPU usage, the longer startup times should be considered.Issue
closes #4973
Unit tests
Documentation
☑️
Changelog
☑️
Bumping the serialization version id
❌