Fix validation of running period for NeTEx flexible lines

[vpaturet]

Summary

As detailed in #5006 , the calculation of the start and end of the transit period is wrong when a flexible line contains both fixed stops and flexible areas.
The construction of TripTimes in this case is necessary since Raptor makes use of flexible lines when they contain at least 2 fixed stops. Moreover these TripTimes are also used to provide flexible trip information in the TransModel API.

This PR relaxes the validation rule of the running period for flexible trips. Flexible trips are identified with Route.getFlexibleLineType() , so this fix covers only flexible lines imported from NeTEx datasets.

Issue

Partially fixes #5006

Unit tests

✅

Documentation

No

[leonardehrenfried]

I think you want to have trip times so you can look them up in the API, isn't it? That was the reason we added them.

Can you check that the Transmodel API still returns the same values before and after this change?

[t2gran]

This is poor design, reusing TripTimes to pass on information - breaking some core assumptions in TripTimes (purpose is scheduled routing). I think we need to discuss it.

[hannesj]

The mapping is required for trips containing at least two scheduled fixed stops, as they will be used in RAPTOR routing for intermediate legs. However those might not have a scheduled time on the first stop, which will break the sorting.

This information need to be stored somewhere, so that we can show the time windows for the flex trips in the APIs

[vpaturet]

Then obviously if these trips are used in Raptor, they cannot be filtered out at mapping time.
A quick fix, short of a better solution, would be to relax the validation of the running period for flexible trips, using Route.getFlexibleLineType() to identify these trips.
(This does not solve the issue for GTFS-flex nor address the underlying design issue)

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (c805184) 64.08% compared to head (7bd10ac) 64.08%.

❗ Current head 7bd10ac differs from pull request most recent head 8f943a6. Consider uploading reports for the commit 8f943a6 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             dev-2.x    #5007   +/-   ##
==========================================
  Coverage      64.08%   64.08%           
  Complexity     13593    13593           
==========================================
  Files           1676     1676           
  Lines          66288    66288           
  Branches        7154     7155    +1     
==========================================
+ Hits           42479    42483    +4     
+ Misses         21430    21426    -4     
  Partials        2379     2379           

Impacted Files	Coverage Δ
...ithm/raptoradapter/transit/TripPatternForDate.java	72.50% <0.00%> (-1.86%)	⬇️

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.