Fix precedence rules for NeTEx flexible line booking information #5021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpaturet
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5021 +/- ##
==========================================
Coverage 64.32% 64.32%
+ Complexity 13804 13783 -21
==========================================
Files 1689 1689
Lines 66770 66799 +29
Branches 7189 7200 +11
==========================================
+ Hits 42947 42971 +24
- Misses 21417 21419 +2
- Partials 2406 2409 +3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
vpaturet
force-pushed
the
otp2_allow_netex_bookinginfo_overriding
branch
from
748500f
to
c794e41
Compare
t2gran
approved these changes
Apr 13, 2023
leonardehrenfried
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As detailed in #5020, the current algorithm for importing booking information from NeTEx flexible lines does not allow for fine-grained merging of the different booking properties specified at different levels (FlexibleLine, ServiceJourney, StopPointInJourneyPattern).
This PR changes the import logic to make it possible to define common properties at a higher level (for example contact information at the flexible line level), and define more specific properties at lower level.
Issue
closes #5020
Unit tests
Added unit test.
Documentation
No